Skip to content

CI: update the must passed jobs' name in .asf.yaml #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Jun 19, 2025

For the contexts, should be the names of checks that must pass, which are the jobs' name property, instead of the steps' id value.

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@tuhaihe tuhaihe changed the title CI: update the must passed jobs' name in .asf.yaml [skip ci ] CI: update the must passed jobs' name in .asf.yaml Jun 19, 2025
@tuhaihe tuhaihe changed the title [skip ci ] CI: update the must passed jobs' name in .asf.yaml [skip ci] CI: update the must passed jobs' name in .asf.yaml Jun 19, 2025
@tuhaihe tuhaihe marked this pull request as draft June 19, 2025 08:55
For the contexts, should be the names of checks that must pass, which
are the jobs' `name` property, instead of the steps' id value.
@tuhaihe tuhaihe force-pushed the update-check-context branch from 7ee82a0 to 37efa4f Compare June 19, 2025 09:35
@tuhaihe tuhaihe changed the title [skip ci] CI: update the must passed jobs' name in .asf.yaml CI: update the must passed jobs' name in .asf.yaml Jun 19, 2025
@tuhaihe tuhaihe marked this pull request as ready for review June 19, 2025 10:03
@tuhaihe tuhaihe requested a review from edespino June 19, 2025 10:04
@tuhaihe
Copy link
Member Author

tuhaihe commented Jun 20, 2025

Can see the checks are set as required, except:

  • Apache Cloudberry Build / prepare-test-matrix (pull_request)
  • Apache Cloudberry Build Debug / check-skip (pull_request)
  • Apache Cloudberry Build Debug / ic-cbdb-parallel (pull_request)
  • Apache Cloudberry Build Debug / prepare-test-matrix (pull_request)

The results are the same as the original set, like the checks in #1171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant