-
Notifications
You must be signed in to change notification settings - Fork 166
Add macro documentation comments to AC_DEFINE for FTS and OpenSSL option #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yjhjstz thanks!
During my test, after running autoreconf -i
, the file pg_config.h.in
also had some related updates:
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: src/include/pg_config.h.in
Untracked files:
(use "git add <file>..." to include in what will be committed)
src/include/pg_config.h.in~
Could you help take a look again? Thanks!
pg_config.h.in is automatically generated by autoheader, which dynamically creates comment templates based on the macro definitions (e.g., AC_DEFINE, AC_CHECK_FUNCS) in your configure.ac file. added |
Thanks. One more point is that after pulling your branch, I ran the command Other than this, all looks good to me. Thanks! |
I think no need. |
Maybe need to rerun the cmd Without any change, after running the cmd, some files changed:
|
updated. |
Fixes #1058
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheck
make -C src/test installcheck-cbdb-parallel
Impact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions