Skip to content

Add macro documentation comments to AC_DEFINE for FTS and OpenSSL option #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yjhjstz
Copy link
Member

@yjhjstz yjhjstz commented Jun 11, 2025

Fixes #1058

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@yjhjstz yjhjstz requested a review from tuhaihe June 11, 2025 02:15
Copy link
Member

@tuhaihe tuhaihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yjhjstz thanks!

During my test, after running autoreconf -i, the file pg_config.h.in also had some related updates:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   src/include/pg_config.h.in

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	src/include/pg_config.h.in~

Could you help take a look again? Thanks!

@yjhjstz
Copy link
Member Author

yjhjstz commented Jun 11, 2025

Hey @yjhjstz thanks!

During my test, after running autoreconf -i, the file pg_config.h.in also had some related updates:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   src/include/pg_config.h.in

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	src/include/pg_config.h.in~

Could you help take a look again? Thanks!

pg_config.h.in is automatically generated by autoheader, which dynamically creates comment templates based on the macro definitions (e.g., AC_DEFINE, AC_CHECK_FUNCS) in your configure.ac file.

added src/include/pg_config.h.in.

@tuhaihe
Copy link
Member

tuhaihe commented Jun 12, 2025

Could you help take a look again? Thanks!

pg_config.h.in is automatically generated by autoheader, which dynamically creates comment templates based on the macro definitions (e.g., AC_DEFINE, AC_CHECK_FUNCS) in your configure.ac file.

added src/include/pg_config.h.in.

Thanks. One more point is that after pulling your branch, I ran the command autoreconf -i again, the file configure had some changes, is there a need to commit its changes again?

Other than this, all looks good to me. Thanks!

@yjhjstz
Copy link
Member Author

yjhjstz commented Jun 12, 2025

Could you help take a look again? Thanks!

pg_config.h.in is automatically generated by autoheader, which dynamically creates comment templates based on the macro definitions (e.g., AC_DEFINE, AC_CHECK_FUNCS) in your configure.ac file.
added src/include/pg_config.h.in.

Thanks. One more point is that after pulling your branch, I ran the command autoreconf -i again, the file configure had some changes, is there a need to commit its changes again?

Other than this, all looks good to me. Thanks!

I think no need.

@tuhaihe tuhaihe requested a review from edespino June 12, 2025 03:05
@tuhaihe
Copy link
Member

tuhaihe commented Jun 26, 2025

Maybe need to rerun the cmd autoreconf -i to generate the new file.

Without any change, after running the cmd, some files changed:

	modified:   configure
	modified:   src/include/pg_config.h.in

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	src/include/pg_config.h.in~

@yjhjstz
Copy link
Member Author

yjhjstz commented Jun 26, 2025

Maybe need to rerun the cmd autoreconf -i to generate the new file.

Without any change, after running the cmd, some files changed:

	modified:   configure
	modified:   src/include/pg_config.h.in

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	src/include/pg_config.h.in~

Maybe need to rerun the cmd autoreconf -i to generate the new file.

Without any change, after running the cmd, some files changed:

	modified:   configure
	modified:   src/include/pg_config.h.in

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	src/include/pg_config.h.in~

updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Warns return when running autoreconf -i after changing the configure.ac file
3 participants