Include ADO's 25R2/sp01 changes #1077
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
…uild (#1059) Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: afernand <alex.fernandezluces@ansys.com>
….10.0 in the general-dependencies group (#1073) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Integrates ADO’s 25R2/sp01 updates into the Prime meshing internals:
- Cleans up and centralizes logging in the Docker-based server launch path
- Adds preprocessing to sanitize hyperfoam coefficient data
- Fixes a typo in the hyperfoam coefficient string assembly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ansys/meshing/prime/internals/launcher.py | Removed an inconsistent logger call and standardized output when using Docker server |
| src/ansys/meshing/prime/core/mapdlcdbexportutils.py | Introduced float conversion for coefficient data and corrected a variable typo in string formatting |
Comments suppressed due to low confidence (3)
src/ansys/meshing/prime/core/mapdlcdbexportutils.py:896
- Introduce unit tests for the new data normalization logic to ensure None values are skipped and all numeric strings are correctly converted to floats.
data = {
src/ansys/meshing/prime/internals/launcher.py:266
- [nitpick] Use the project’s logging framework instead of print to maintain consistency and log levels. For example:
logging.getLogger('PyPrimeMesh').info('Using server from container: %s', container_name).
print('using server from docker : The container name ', container_name)
src/ansys/meshing/prime/internals/launcher.py:271
- The removed logger call used a comma without a format specifier, which would log a tuple rather than interpolating the container name. If reintroducing, use a format string or pass
%sin the message.
)
|
The documentation for this pull request will be available at https://prime.docs.pyansys.com/pull/1077. Please allow some time for the documentation to be deployed. |
github-actions
bot
added
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: wrap with feature edges)