-
Notifications
You must be signed in to change notification settings - Fork 23
FEAT: Add lock option removal for save_as
method
#1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (29.41%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
==========================================
- Coverage 86.40% 86.07% -0.33%
==========================================
Files 39 39
Lines 2537 2550 +13
==========================================
+ Hits 2192 2195 +3
- Misses 345 355 +10 🚀 New features to boost your workflow:
|
Co-authored-by: Kerry McAdams <58492561+klmcadams@users.noreply.github.com>
This pull request introduces enhancements to the
save_as
method in theapp.py
file, including the addition of aremove_lock
option, and replaces warnings with logging for better error handling. Additionally, it updates the changelog to document these changes.Enhancements to
save_as
method:remove_lock
parameter to thesave_as
method, allowing users to remove lock files before saving the project. This provides more flexibility when dealing with locked project files.save_as
by logging detailed error messages, including a hint for resolving lock-related issues, and raising exceptions when saving fails.Logging improvements:
warnings.warn
withself.log_warning
in theopen
method to standardize logging and improve message clarity.