Skip to content

Fix socket.gethostbyaddr(ip) error when no reverse DNS available. #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yeguang-xue
Copy link

@yeguang-xue yeguang-xue commented Jul 11, 2025

Description

For ip addresses without reverse DNS, socket.gethostbyaddr(ip) will fail. We can simply use ip address for hostname display.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

Summary by Sourcery

Bug Fixes:

  • Prevent socket.gethostbyaddr errors by using the IP address directly for hostname when reverse DNS lookup would fail

For ip addresses without reverse DNS, socket.gethostbyaddr(ip) will fail. We can simply use ip address for hostname display.
@yeguang-xue yeguang-xue requested a review from a team as a code owner July 11, 2025 19:42
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link
Contributor

sourcery-ai bot commented Jul 11, 2025

Reviewer's Guide

Revises the hostname resolution logic to avoid socket.gethostbyaddr failures by using the IP address directly when no reverse DNS is available.

Class diagram for updated hostname resolution in mapdl_grpc.py

classDiagram
    class MapdlGrpc {
        - _hostname
        __init__(ip)
    }
    MapdlGrpc : __init__() sets _hostname to "localhost" if ip in ["127.0.0.1", "127.0.1.1", "localhost"]
    MapdlGrpc : __init__() sets _hostname to ip otherwise
Loading

File-Level Changes

Change Details Files
Use IP address as fallback instead of reverse DNS lookup
  • Removed socket.gethostbyaddr(ip)[0] call in hostname assignment
  • Replaced it with a direct use of the IP string for non-loopback addresses
src/ansys/mapdl/core/mapdl_grpc.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yeguang-xue - I've reviewed your changes - here's some feedback:

  • Consider wrapping socket.gethostbyaddr in a try/except so you still attempt reverse DNS and only fall back to the raw IP when lookup fails.
  • It might be helpful to emit a warning or log entry when DNS resolution fails, so users can more easily diagnose hostname lookup issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider wrapping socket.gethostbyaddr in a try/except so you still attempt reverse DNS and only fall back to the raw IP when lookup fails.
- It might be helpful to emit a warning or log entry when DNS resolution fails, so users can more easily diagnose hostname lookup issues.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant