feat: using dpf instead of reader in "results" module #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
- Coverage 91.81% 90.95% -0.86%
==========================================
Files 187 189 +2
Lines 15033 15666 +633
==========================================
+ Hits 13802 14249 +447
- Misses 1231 1417 +186 🚀 New features to boost your workflow:
|
|
Fundamentally, this all needs to be moved to DPF-Post and DPF post needs to have an even simpler API. Right now we have:
I'd rather not make a 5th. There's a potential new hire that will work for the PyAnsys team on DPF-Post and I'd like him to work on this along with you. |
|
On-hold for the moment until I see how pydpf-post develops. |
|
Closing because I do not have the capacity for this. I think eventually we should use |
for more information, see https://pre-commit.ci
|
We are so back... |
…test completion logging
…/pymapdl into feat/using-dpf-for-results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Most of the general info has been moved to #4084)
Migrate most of the backend and set the foundations for following PRs. Aiming to migrate most of the numerical methods. Plotting will be in a follow up PR.
Launch DPF when running in containerThis should not be part of PyMAPDL since if it is local, it will be automatically detected, and if it is remote, we should not own that resource. It could be something for PyMAPDL developers.To migrate
Missing
To be done in follow up PRs
materialsThe material API is lacking many features. So far, we cannot read temperature-dependent materials, and it seems neither some electric properties like permitivity.
See:
mesh: Requires replicate a full class. It will be a different issue.cylindrical_nodal_stress.element_solution_dataThis requires a mapping sort of:
nodal_boundary_conditionsnodal_input_forceparse_coordinate_systemresult_dof: Return a list of degrees of freedom for a given result number.section_dataDone
available_resultselement_componentselement_lookupelement_stressfilenamen_resultsn_sectornodal_accelerationnodal_displacementnodal_elastic_strainnodal_plastic_strainnodal_reaction_forcesnodal_solutionnodal_static_forcesnodal_stressnodal_temperaturenodal_thermal_strainnodal_time_historynodal_velocitynode_componentsparse_step_substeppathlib_filenameprincipal_nodal_stresstime_valuesversionTo not migrate.
A
NotImplementedErrorwill be raised.text_result_tableUsed for the text in the plots. Not porting it.write_tables: Write binary tables to ASCII.read_record: Read a record from the opened file. Records are hidden in DPF.overwrite_element_solution_record: DPF cannot write solution files.overwrite_element_solution_records: DPF cannot write solution files.cs_4x4- I couldn't make it work locally, so I'm not porting it. It will raise a not implemented error.solution_infoIt doesn't make sense to be ported at the moment.
There are many methods which are duplicate frommapdl.post_processing, I will probably redirect one to another (I don't know which one should prevail, probably post-processing).DPFResultclass should provide a way to manipulate RST files without having an MAPDL instance alive.Full list of Reader class methods
The complete lists of functions in that class are:
Show full list of Result class functions
Notes
Launch DPF when running in containerThis should not be part of PyMAPDL since if it is local, it will be automatically detected, and if it is remote, we should not own that resource. It could be something for PyMAPDL developers.Summary by Sourcery
Replace the legacy reader‐based results interface with a new DPF backend: introduce a global switch to toggle backends, implement and expose the
DPFResultclass with migrated public APIs using ansys-dpf-core, update test infrastructure and CI workflows to support DPF testing, and refine misc, launcher, and pytest utilities to accommodate the change.New Features:
use_reader_backendswitch in MAPDL.DPFResultclass underansys.mapdl.core.reader.resultmigrating public result APIs to use ansys-dpf-core.get_ipandparse_ip_routefor IP detection and switch GRPC/Docker connection logic.Bug Fixes:
MapdlGrpc.sysand clarify assertion error when reusing MAPDL instances.Enhancements:
PYMAPDL_ADDITIONAL_SWITCHESin headers.mapdl.resultfile‐path handling to create isolated temp directories and enrich FileNotFoundError messages._parse_ip_routeusage in launcher and misc modules.CI:
TEST_DPF_BACKENDenvironment variable in CI workflows to enable/disable DPF tests.Documentation:
Tests:
tests/test_result.pyand update fixtures fortest_dpf_backend.tests/conftest.py,tests/common.py, and test launcher to integrate DPF backend testing.