Fix: remove I/O Blocking code on message processing parts #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR replace #819 |
… to avoid blocking in case of big file
1yam
force-pushed
the
1yam-non-io-blocking
branch
from
a869f13 to
feb0dce
Compare
nesitor
reviewed
Jul 17, 2025
Comment on lines
+16
to
+22
| async def api_get_request(session: aiohttp.ClientSession, base_uri, method, timeout=1): | ||
| uri = f"{base_uri}/api/v0/{method}" | ||
| try: | ||
| async with SESSIONS[timeout].get(uri) as resp: | ||
| async with session.get(uri) as resp: | ||
| if resp.status != 200: | ||
| result = None | ||
| else: | ||
| result = await resp.json() | ||
| return None | ||
| return await resp.json() |
There was a problem hiding this comment.
Here we are ignoring the timeout provided by the argument. If the session timeout is handled outside just removing the parameter, but if the argument is used by other methods that don't handle the timeout from their own, we need to use it inside the method to prevent issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove I/O blocking operations on parts used by message processing to bring back message parallelization
Related Clickup or Jira tickets : ALEPH-526
Self proofreading checklist
Changes
This pull request introduces significant changes to improve asynchronous handling across multiple modules, enhance efficiency, and ensure non-blocking operations. Key updates include replacing synchronous file and I/O operations with asynchronous alternatives, introducing semaphores to limit concurrent requests, and refactoring code to use shared
aiohttp.ClientSessioninstances for HTTP requests.Asynchronous Enhancements:
src/aleph/handlers/content/aggregate.py: Updated_prepend_to_aggregateand_update_aggregateto useasyncio.to_threadfor non-blocking execution ofmerge_aggregate_elements. [1] [2]src/aleph/services/storage/fileystem_engine.py: Replaced synchronous file operations with asynchronous equivalents usingaiofiles, includingread,write,delete, andexistsmethods.HTTP Request Optimization:
src/aleph/services/p2p/http.py: Refactoredapi_get_requestto use a sharedaiohttp.ClientSessioninstead of maintaining separate session instances, improving resource management. Added semaphores to limit concurrent calls inget_peer_hash_contentandrequest_hash. [1] [2] [3]src/aleph/services/p2p/jobs.py: Introducedrequest_versionto handle peer version checks usingaiohttp.ClientSessionand asynchronous tasks. Refactoredtidy_http_peers_jobto utilizerequest_versionfor better scalability. [1] [2]Code Cleanup:
src/aleph/handlers/content/post.py: Removed debug print statements fromupdate_balancesfor cleaner logging.These changes collectively enhance the system's scalability, responsiveness, and maintainability by leveraging asynchronous programming patterns effectively.
How to test
This PR doesn't add any breaking change, it's just running things in Non I/O blockign way