feat: Implement historical pricing for message cost recalculation #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesitor
reviewed
Jul 17, 2025
| ), | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
I think that we shouldn't have to modify a migration already executed on the rest of the CCNs to prevent unconsistencies on the database.
Comment on lines
+176
to
+186
| """Force recalculation of message costs in chronological order with historical pricing. | ||
|
|
||
| This endpoint will: | ||
| 1. Get all messages that need cost recalculation (if item_hash provided, just that message) | ||
| 2. Get the pricing timeline to track price changes over time | ||
| 3. Sort messages chronologically (oldest first) | ||
| 4. For each message, use the pricing model that was active when the message was created | ||
| 5. Delete existing cost entries and recalculate with historical pricing | ||
| 6. Store the new cost calculations | ||
| """ | ||
|
|
There was a problem hiding this comment.
As we commented, I think that we should to add a kind of temporary token authentication based to prevent that endpoint to be used by people to DDOS the CCN as the endpoints takes time to re-process everything again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements historical pricing support for message cost recalculation, ensuring costs are calculated using the pricing models that were active when messages were originally created.
Key Changes
🔧 New Pricing Timeline System
⚡ Enhanced Cost Recalculation
🔄 Migration Refactoring
🧪 Comprehensive Testing
API Endpoints
Benefits
✅ Historical Accuracy: Costs calculated using pricing active when messages were created✅ Performance: Efficient timeline processing without repeated DB queries✅ Maintainability:
Reusable pricing utilities reduce code duplication✅ Robustness: Comprehensive error handling and extensive test coverage