Fix syncthing plugin #223
Open
Fix syncthing plugin #223
+84
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reverted my changes on lines 58-64. I'd changed them while experimenting with why settings was broken and forgot to revert. As an aside, as far as I can tell the option does nothing, but I added it back just to avoid changing anything I didn't need to. |
|
Oh forgot to include, here's a before and after of the settings menu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncthing wasn't working properly. Was throwing errors about st not being defined any time the user types in albert, and the error
[crit:albert.python] Unable to cast Python instance of type <class 'NoneType'> to C++ type 'QString'when opening settings, displaying a blank window instead of the api key field. This PR:Screenshots
Valid api key
Invalid api key
No api key