Create basic app structure. Add deploy-dev pipeline #7

AmsterGet · 2023-03-01T16:06:09Z

TODO (will be a part of another PR):

Add SCSS
Add aliases for main dirs
Create common page Layout component

* feat: add telegram token validation * feat: fix comments * feat: telegram token validation fix comments * Added tsconfig build to not block development. --------- Co-authored-by: Roman Sluka <r.sluka@itransition.com>

src/setupProxy.js

AmsterGet · 2023-04-26T18:23:22Z

@Nikkov17 @skyRoma
Please check out the latest built version - https://aikray.github.io/menu-bot-front/
Don't forget to view on mobile screens :)

Nikkov17 · 2023-05-01T19:24:20Z

src/index.css

@@ -1,4 +1,18 @@
+@import "./core/styles/variables.css";
+
+html {


we can combine html, root, body common styles

src/pages/common/footer/Footer.module.css

Nikkov17 · 2023-05-01T19:42:59Z

src/pages/common/footer/Footer.tsx

+
+const cx = classNames.bind(styles);
+
+interface FooterProps {}


is it needed?

Actually no, until we will paste some page specific props to Footer.

So let's remove the dead code for now?

src/providers/store-provider/storeContext.ts

…app-structure

skyRoma · 2023-04-26T18:33:08Z

src/pages/profile-page/ProfilePage.module.css

Please, change all file names to snake-case

As we agreed before or let's agree this CapitalCamelCase approach just for component file names. Both cases work for me, but they should be consistent across the whole project.

skyRoma · 2023-05-04T13:04:23Z

.github/workflows/deploy-dev.yml

really minor, but could you please make the step names consistent with the 1st action

skyRoma · 2023-05-04T13:08:49Z

.github/workflows/deploy-dev.yml

@@ -15,10 +15,16 @@ jobs:
        with:
          node-version: 18

+      - name: Configure git profile


Is it really needed now? Since I don't remember that we used it on the previous project. Maybe the issue is in the token permissions or the token type? I think I used the classic token type

skyRoma · 2023-05-04T14:09:22Z

src/App.css

-    transform: rotate(360deg);
-  }
+  height: 100%;
+  width: 100%;


Width is 100% by default, sicne it's a <div>, so please remove this prop

skyRoma · 2023-05-04T14:53:57Z

src/providers/initial-data-provider/InitialDataProvider.tsx

+  children,
+}: IInitialDataProviderProps) => {
+  // TODO: Use city from Telegram
+  const extractCity = (): string =>


it everytime will be null for the first visit, so use :string | null and remove as string below.
Or use localStorage.getItem(LOCAL_STORAGE_SAVED_CITY_KEY) || ''

skyRoma · 2023-05-04T21:49:53Z

src/pages/search-page/search-with-list/SearchWithList.tsx

+      placeholder="Input search text"
+      allowClear
+      onChange={onChange}
+      style={{ width: '100%' }}


Please, use classes for styles

As I can see it is even 100% by default

skyRoma · 2023-05-04T22:11:00Z

src/pages/search-page/search-with-list/SearchWithList.tsx

+  entities?: string[];
+  onChange: (event: ChangeEvent<HTMLInputElement>) => void;
+  onEntityClick?: (entityName: string) => void;
+  entityLinkTarget: string;


Should this also be an optional property? I suppose you wanted to make this component reusable even without list, just with input? But in general, I would suggest using composition in such cases (to have 2 separate components, search and list). But as for now we don't need just search (without list) let's make all properties required

And please group them together (first fields then methods). And for the future lets place the optional ones below the required ones

skyRoma · 2023-05-04T22:23:40Z

src/pages/search-page/supported-searches/restaurants-search/RestaurantsSearch.tsx

+export const RestaurantsSearch = () => {
+  const { selectedCity } = useContext(StoreContext);
+  const [restaurants, setRestaurants] = useState<string[]>(
+    restaurantsByCities[selectedCity] || []


I suppose we won't have a city in the App if we don't have any restaurant for this city so you can remove || []

skyRoma · 2023-05-04T22:55:14Z

src/providers/initial-data-provider/InitialDataProvider.tsx

Sorry, but I didn't get why do we need this additional provider? why not just use only one StoreProvider? For me it looks unnecessary completed

like this for example

import { LOCAL_STORAGE_SAVED_CITY_KEY } from 'providers/store-provider/constants'; import { ReactElement, useCallback, useState } from 'react'; import { IStoreContext, StoreContext, StoreDispatchContext, } from './storeContext'; interface IStoreProviderProps { children: ReactElement; } const extractCity = (): string => localStorage.getItem(LOCAL_STORAGE_SAVED_CITY_KEY) || ''; const saveCityLocally = ({ selectedCity }: Partial<IStoreContext>) => { localStorage.setItem(LOCAL_STORAGE_SAVED_CITY_KEY, String(selectedCity)); }; const initialStore = { selectedCity: extractCity(), }; export const StoreProvider = ({ children }: IStoreProviderProps) => { const [store, setStore] = useState(initialStore); const updateStoreProperties = useCallback( (storeProperties: Partial<IStoreContext>) => { setStore(prevStore => ({ ...prevStore, ...storeProperties, })); saveCityLocally(storeProperties); }, [] ); return ( <StoreContext.Provider value={store}> <StoreDispatchContext.Provider value={updateStoreProperties}> {children} </StoreDispatchContext.Provider> </StoreContext.Provider> ); };

skyRoma · 2023-05-04T23:13:34Z

src/providers/store-provider/storeContext.ts

+  selectedCity: string;
+}
+
+export type StoreDispatchType = (storeProperty: Partial<IStoreContext>) => void;


This is not used outside, please remove export.
The same for defaultStore below

AmsterGet force-pushed the basic-app-structure branch from 2558b52 to 27c88c9 Compare March 1, 2023 16:09

AmsterGet force-pushed the basic-app-structure branch from 2a7ce59 to 32bc5a0 Compare April 5, 2023 17:12

AmsterGet requested review from skyRoma and Nikkov17 April 13, 2023 16:44

Nikkov17 and others added 10 commits April 17, 2023 21:48

feat: add telegram token validation (#9)

9e96c85

* feat: add telegram token validation * feat: fix comments * feat: telegram token validation fix comments * Added tsconfig build to not block development. --------- Co-authored-by: Roman Sluka <r.sluka@itransition.com>

Create basic app structure. Add deploy-dev pipeline

098c92e

Add mocked search for cities and restaurants

f23da3c

Configure git

5f96996

Update repo info. Add home page tab

80a4491

Remove quote

b6a8069

Remove home page. Adjust styles. Fix GitHub pages deployment

11cca0a

Add empty profile page

e3584df

Add basic store

a06bb03

Revert API health check

7db6e85

AmsterGet force-pushed the basic-app-structure branch from 75a030e to 7db6e85 Compare April 25, 2023 21:17

Nikkov17 reviewed Apr 26, 2023

View reviewed changes

src/setupProxy.js Outdated Show resolved Hide resolved

Fix build. Update navigation buttons

4076f86

AmsterGet requested a review from Nikkov17 April 26, 2023 18:19

Ignore console statements

707abd7

AmsterGet linked an issue Apr 26, 2023 that may be closed by this pull request

basic ui. Main page with list of restaurants. #4

Open

Nikkov17 reviewed May 1, 2023

View reviewed changes

skyRoma force-pushed the main branch from c0a16be to 34050f9 Compare May 4, 2023 13:19

Merge branch 'main' of https://github.com/AIKRAY/menu-bot into basic-…

633c09e

…app-structure

skyRoma requested changes May 4, 2023

View reviewed changes

		@@ -1,4 +1,18 @@
		@import "./core/styles/variables.css";

		html {

Create basic app structure. Add deploy-dev pipeline #7

Are you sure you want to change the base?

Create basic app structure. Add deploy-dev pipeline #7

Uh oh!

Conversation

AmsterGet commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

AmsterGet commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skyRoma May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AmsterGet commented Mar 1, 2023 •

edited

Loading

AmsterGet commented Apr 26, 2023 •

edited

Loading

skyRoma May 4, 2023 •

edited

Loading