Skip to content

WIP: SVAE #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

WIP: SVAE #52

wants to merge 14 commits into from

Conversation

nmheim
Copy link
Member

@nmheim nmheim commented Nov 15, 2019

No description provided.

@nmheim nmheim changed the title SVAE WIP: SVAE Nov 15, 2019
@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #52 into master will increase coverage by 1.81%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   69.86%   71.68%   +1.81%     
==========================================
  Files          13       19       +6     
  Lines         219      339     +120     
==========================================
+ Hits          153      243      +90     
- Misses         66       96      +30
Impacted Files Coverage Δ
src/GenerativeModels.jl 100% <ø> (ø) ⬆️
src/utils/utils.jl 24.52% <0%> (-0.97%) ⬇️
src/pdfs/hs_uniform.jl 100% <100%> (ø)
src/models/svae.jl 27.77% <27.77%> (ø)
src/pdfs/cmeanconc_vmf.jl 69.23% <69.23%> (ø)
src/pdfs/abstract_cvmf.jl 72.72% <72.72%> (ø)
src/pdfs/vonmisesfisher.jl 80% <80%> (ø)
src/utils/vmf.jl 93.47% <93.47%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddff8de...4dcb901. Read the comment docs.

@honzabim
Copy link
Collaborator

I think you can merge it now... SVAE vanilla should work. It has very high rec. error but that might be due to different working of the SVAE and need to train longer or something. I can't really work on it any longer since Pevnak wants me to do something else for Avast before I leave. I am sorry.

@nmheim nmheim self-assigned this Nov 19, 2019
Copy link
Member Author

@nmheim nmheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you very much! :)

@@ -0,0 +1,67 @@
export CMeanVarVMF
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename this to CMeanConcVMF? same goes for the filename

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, let's rename that. I am sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants