-
Notifications
You must be signed in to change notification settings - Fork 3
WIP: SVAE #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 69.86% 71.68% +1.81%
==========================================
Files 13 19 +6
Lines 219 339 +120
==========================================
+ Hits 153 243 +90
- Misses 66 96 +30
Continue to review full report at Codecov.
|
I think you can merge it now... SVAE vanilla should work. It has very high rec. error but that might be due to different working of the SVAE and need to train longer or something. I can't really work on it any longer since Pevnak wants me to do something else for Avast before I leave. I am sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thank you very much! :)
src/pdfs/cmeanvar_vmf.jl
Outdated
@@ -0,0 +1,67 @@ | |||
export CMeanVarVMF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rename this to CMeanConcVMF
? same goes for the filename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, let's rename that. I am sorry.
No description provided.