Skip to content

Add support for FTP extension. #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Add support for FTP extension. #166

wants to merge 1 commit into from

Conversation

desrosj
Copy link
Member

@desrosj desrosj commented Apr 14, 2025

From #165:

Referencing this issue: #164
And this core patch: WordPress/wordpress-develop#8589
The idea is to provide FTP testing features to the image to test and debug FTP-related topics.

The GHA workflows do not currently support pull requests that originate from a fork.

cc @SirLouen

@desrosj desrosj self-assigned this Apr 14, 2025
Copy link

github-actions bot commented Apr 14, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: SirLouen <sirlouen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@SirLouen
Copy link

From #165:

Referencing this issue: #164
And this core patch: WordPress/wordpress-develop#8589
The idea is to provide FTP testing features to the image to test and debug FTP-related topics.

The GHA workflows do not currently support pull requests that originate from a fork.

cc @SirLouen

How shall we PR then?

@desrosj
Copy link
Member Author

desrosj commented Apr 14, 2025

We need to look at adding support for this. Because the workflows result in containers that are published, it needs to be through through carefully. I know it's a poor contributor experience. Apologies for that.

This one can be used for now. It seems there's something off in the proposed changes, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants