Skip to content

user wont be logged in before migration ends #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

user wont be logged in before migration ends #2537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb7ce98
user wont be logged in before migration ends
ludwikkazmierczak Jan 8, 2019
06b3a31
Merge branch 'master' into cnw-fix-anon
ludwikkazmierczak Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .../com/wikia/webdriver/testcases/desktop/createawikitests/CreateWikiTestsLoggedOutUser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ public void loggedOutUserCanCreateNewWiki() {
new WikiFactory().setIsTestWiki(article.getWikiID(), true);

article.verifyWikiTitleHeader(wikiName);
article.verifyUserLoggedIn(credentials.userName10);
// Caused by: https://wikia-inc.atlassian.net/browse/PLATFORM-3829
// User wont be logged in after the migration is finished, since we are not going to sync access token over in CNW
// TODO: Enable once wikia.com -> fandom.com migration is complete
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INFO Complete the task associated to this TODO comment. rule

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ludwikkazmierczak to repo przetrwalo sporo dluzej niz moglem sadzic, ale widze ze juz umarlo :D

// article.verifyUserLoggedIn(credentials.userName10);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR This block of commented-out lines of code should be removed. rule

}
}