-
Notifications
You must be signed in to change notification settings - Fork 124
Infinispan client update #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vNext
Are you sure you want to change the base?
Conversation
@miuponn Thank you for the PR. Please sign the CLA (see above comment for further information). Also, it's good to sign the commits. |
@idlewis As you had raised this issue, please review the PR as well. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
Does this also need to go in 25.0.0.5 (as well as latest)?
Do we also need update our docs?
Thank you for the review, Iain. 25.0.0.6 will be released today (and 25.0.0.5 will be removed from support). Let's target this for 25.0.0.7, in which case, making the changes only to |
Please hold off merging as the |
Fixes #673
Previously hardcoded client version in pom.xml generation is replaced with configurable version at build time or via env in Dockerfile.
Adds support for the following environment variables and build args:
versions:use-latest-releases