Skip to content

fix: fast track proposal script #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

mrshiposha
Copy link
Contributor

No description provided.

@@ -28,7 +29,7 @@ async function main() {
proposalHash = proposal;
}

const voringPeriod = 7200;
const voringPeriod = 1 * DAYS;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14400

Но ведь это даже дольше, по тому что в чате было написано я думал что надо наоборот меньше?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Достаточно чтобы было равно одному дню. Демократия начинает требовать InstantOrigin только если voting period строго меньше сконфигурированного минимального периода фаст-стрека

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14400, почему дольше? Это же буквально один день, у нас так и сконфигуриванно

Copy link
Member

@CertainLach CertainLach Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Честно говоря я вообще не понимаю что тут не так, там же по коду описание стоит

            // Rather complicated bit of code to ensure that either:
            // - voting_period is at least FastTrackVotingPeriod and origin is
            //   FastTrackOrigin; or
            // - InstantAllowed is true and origin is InstantOrigin.
        pub FastTrackVotingPeriod: BlockNumber = 10 * MINUTES;

И у нас изначально 7200 is at least 10 minutes & origin = fast track origin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У нас на разных рантаймах разные тайминги, на Кварце это один день:

pub FastTrackVotingPeriod: BlockNumber = 1 * DAYS;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На Опале короткий

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А, блин, точно. Теперь всё понял

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я только common тайминги смотрел и не понимал что тут не так)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants