Interactive Modal #194
Draft
Interactive Modal #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please set a versioning label of either |
|
@krowvin How does this work on mobile? I'd almost rather see a ModalResizable component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@msweier was asking about making the modal interactive.
This PR adds the functionality to make it resizable and movable.
Thoughts on if we should make this opt in instead of always movable/resizable?
I also saw this library for making things draggable, not sure if we want to add another dependency if the below commits suffice?
https://github.com/react-grid-layout/react-draggable
May want to also provide opacity control for behind the modal?