Skip to content

Accordion Props to Control State #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

krowvin
Copy link
Contributor

@krowvin krowvin commented Mar 31, 2025

This pull request includes significant updates to the Accordion component to enhance its functionality and documentation. The most important changes include updating the import statements, adding new props to the Accordion component, and updating the documentation to reflect these changes.

Enhancements to Accordion component:

Documentation updates:

Copy link

Please set a versioning label of either major-bump, minor-bump, or patch-bump to the pull request.

@willbreitkreutz willbreitkreutz requested a review from Copilot April 7, 2025 15:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@krowvin
Copy link
Contributor Author

krowvin commented Apr 7, 2025

Will remove id for props spread and test to make sure multiple still work

@krowvin
Copy link
Contributor Author

krowvin commented May 30, 2025

id removed, ready for merge/review

@willbreitkreutz willbreitkreutz self-requested a review June 2, 2025 16:08
Copy link
Contributor

@willbreitkreutz willbreitkreutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just pass all props down to the Accordion body rather than just the id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants