-
Notifications
You must be signed in to change notification settings - Fork 19
Fix Timeseries/recent endpoint speed #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
… timeseries-endpoint-speed
… still updating individual pieces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. Definitely need to chew on it a bit. Fairly complex query, though I doubt unnecessarily so.
.from(baseIds); | ||
|
||
// references to appropriate year tables | ||
Table<?> AT_TSV_2023_TABLE = table(name("AT_TSV_2023")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be AT_TSV_PREV_YEAR and AT_TSV_CURRENT_YEAR and calculated at usage. Otherwise we'll have to remember to update them constantly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup you're correct. I just had those as place holders for now.
Proposed query update that changes a single Timeseries/Recent request from 30 seconds down to half a second on our SWT db export.