Skip to content

[not ready] artisinal #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[not ready] artisinal #4

wants to merge 7 commits into from

Conversation

morganherlocker
Copy link
Member

hand-made artisinal buffers -- no jsts required

@wboykinm
Copy link

Man, this one is a pain.

@morganherlocker
Copy link
Member Author

@wboykinm yeah, really want to knock this one out, but only so many hours in a day, and algorithms are hard. :/

@arkhemlol
Copy link

I'm really really looking for this to be merged!

@DenisCarriere
Copy link
Member

@morganherlocker Any luck on this PR? I know you're a busy man, but this is going to solve a lot of the turf.buffer issues.

@jdesboeufs
Copy link

Current implementation is now broken :(

@morganherlocker
Copy link
Member Author

Current implementation is now broken :(

@jdesboeufs say more? Broken how?

@jdesboeufs
Copy link

Not really broken if installed standalone, but it can't be installed with other modern turf-* modules without many version conflicts.
I can try to update the dependencies and the code, but I don't know if this branch has a future.

I looked at terraformer.Tools.createCircle but when I ask a 500-meters radius circle, I get a 300-meters one. And moreover this part of the lib will probably become unmaintained.
Finally I ended up with an atomic call to PostGIS ST_Buffer, as I'm on the server side. I hope that one day, a native JS solution will land :)

@mclaeysb
Copy link

Hi there! I gave it a try, see #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants