Skip to content

Add rainbow commands #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from
Open

Add rainbow commands #2061

wants to merge 6 commits into from

Conversation

lemonsked
Copy link
Member

Add rainbow commands.

Wild1145
Wild1145 previously approved these changes Jun 9, 2017
@ghost
Copy link

ghost commented Jun 9, 2017

Lemon, are you sure it wont change anything in nicknyan? that is why i made a new color pool!

@Wild1145
Copy link
Member

Wild1145 commented Jun 9, 2017

@marcocorriero As long as they are the same colours within the pool, that is all it is, the same set of colours. Its like having two different brand of water, at the end of the day its still just water.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If formatting is the only issue then this looks good.

@Wild1145
Copy link
Member

@commodore64x Can you line comment on what formatting you thinks needs to be changed? I didnt spot any...

@mayokek
Copy link

mayokek commented Jun 10, 2017

Second eyes are better, I can't spot any.

@JeromSar
Copy link
Member

Needs an approved review from @OxLemonxO or @Wild1145.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Testing required.

@ghost
Copy link

ghost commented Jul 24, 2017

This was already implemented by directly uploading it to the server (it is NOT on GitHub).

@Wild1145
Copy link
Member

@Ivengix Thats not all that helpful...

@Wild1145 Wild1145 added this to the F (5.1) milestone Jun 22, 2019
@Wild1145 Wild1145 self-assigned this Jun 22, 2019
return true;
}

for (String word : Command_tag.FORBIDDEN_WORDS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be changed, assuming there is a merge of the 5.0.2 release as the forbidden tags system has changed. That's something I can change though once the PR goes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants