-
Notifications
You must be signed in to change notification settings - Fork 219
Add rainbow commands #2061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Add rainbow commands #2061
Conversation
src/main/java/me/totalfreedom/totalfreedommod/command/Command_rainbownick.java
Show resolved
Hide resolved
src/main/java/me/totalfreedom/totalfreedommod/command/Command_rainbownick.java
Show resolved
Hide resolved
src/main/java/me/totalfreedom/totalfreedommod/command/Command_rainbownick.java
Show resolved
Hide resolved
src/main/java/me/totalfreedom/totalfreedommod/command/Command_rainbowtag.java
Outdated
Show resolved
Hide resolved
src/main/java/me/totalfreedom/totalfreedommod/command/Command_rainbowtag.java
Outdated
Show resolved
Hide resolved
Lemon, are you sure it wont change anything in nicknyan? that is why i made a new color pool! |
@marcocorriero As long as they are the same colours within the pool, that is all it is, the same set of colours. Its like having two different brand of water, at the end of the day its still just water. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If formatting is the only issue then this looks good.
@commodore64x Can you line comment on what formatting you thinks needs to be changed? I didnt spot any... |
Second eyes are better, I can't spot any. |
Needs an approved review from @OxLemonxO or @Wild1145. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Testing required.
This was already implemented by directly uploading it to the server (it is NOT on GitHub). |
@Ivengix Thats not all that helpful... |
src/main/java/me/totalfreedom/totalfreedommod/command/Command_rainbowtag.java
Outdated
Show resolved
Hide resolved
src/main/java/me/totalfreedom/totalfreedommod/command/Command_rainbowtag.java
Outdated
Show resolved
Hide resolved
return true; | ||
} | ||
|
||
for (String word : Command_tag.FORBIDDEN_WORDS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be changed, assuming there is a merge of the 5.0.2 release as the forbidden tags system has changed. That's something I can change though once the PR goes in.
Add rainbow commands.