Skip to content

Various improvements #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 100 commits into
base: foxy
Choose a base branch
from
Open

Various improvements #32

wants to merge 100 commits into from

Conversation

MatthijsBurgh
Copy link

I have made some various improvements I would like to share with the community.

  • Fixed some various deps missing
  • Removed unused deps
  • Filtered the argv in the tm_driver for ros args
  • Changed includes from double quotes to arrow heads to silence IDE warnings
  • Improved the logic in the CMakelists of the tm_driver
  • Enable compiler warnings/error in the tm_driver
  • Bump C/C++ standard
  • Add ROS industrial CI, which is allowed to fail for now, because the linting is complaining a lot.
  • Rename of techman_robot_get_status to tm_get_status, the package name
  • Cleanup of the image_pub node in tm_get_status

In a future PR I would like to apply the following fixes:

  • Rename demo to tm_demo
  • Rename custom_package to tm_custom_package
  • Rename techman_robot_msgs to tm_robot_msgs
  • Rebame ui_for_debug_and_demo to tm_robot_ui
  • A separate PR to only fix the liniting

@MatthijsBurgh
Fix dep on tf2_geometry_msgs
0fa1338
@MatthijsBurgh
simplify getting args
69fcc6e
@MatthijsBurgh
Make launch file standalone
2bc0ebf
@MatthijsBurgh
Import correct rclcpp header
e04aac0
@MatthijsBurgh
Filter ros args from argv
00402d6
@MatthijsBurgh
Cleanup of CMakeLists
d9947c6
@MatthijsBurgh
Bump c/c++ standards
acfbddf
@MatthijsBurgh
Get rid of ros args parsing
db9a447
@MatthijsBurgh
Add space to fatal logging
b3a2eec
@MatthijsBurgh
change compile definitions
b0b58d6
@MatthijsBurgh
Extend compile definitions to error
bf0cc83
@MatthijsBurgh
Use const char* for print funcs
f56fe0d
@MatthijsBurgh
[actions] add Industrial CI
f50e3f8
@MatthijsBurgh
(dependabot) update GH actions
ae20c02
@MatthijsBurgh
(tm_driver) Correct fatal print
09882e9
@MatthijsBurgh
(tm_driver) small cleanup
a916807
@MatthijsBurgh
(tm_driver) clean return value
57a1fed
@MatthijsBurgh
(tm_driver) const char* print funcs in moveit comp
0c09f3c
@MatthijsBurgh
(tm_driver) better arg handling for moveit comp
9942481
@MatthijsBurgh
(ui_debug_demo) remove robot_server_msgs dep
43ec39e
@MatthijsBurgh
(custom_package) fix compilation
689109b
@MatthijsBurgh
(demo) fix includes to silence IDE warnings
891a926
@MatthijsBurgh
(demo) fix return values
222e2b9
@MatthijsBurgh
(demo) fix FutureReturnCode namespacing
c23491c
@MatthijsBurgh
Rename techman_robot_get_status folder to tm_get_status
1ba823e
@MatthijsBurgh
(tm_get_status) add missing dep
5d61a35
@MatthijsBurgh
(tm_get_status) add missing python deps
208197b
@MatthijsBurgh
(tm_get_status) cleanup internal of image_pub
7cce200
@MatthijsBurgh
(tm_get_status) wait for rosdistro PR
29bb9c9
MatthijsBurgh and others added 30 commits January 5, 2024 11:48
@MatthijsBurgh
Remove exec rights of CMakeLists.txt's
bb5f03c
@MatthijsBurgh
(tm_mod_urdf) make it black
6c76732
@dependabot @MatthijsBurgh
Bump actions/checkout from 3 to 4
9c10a9a 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump actions/cache from 3 to 4 (#3)
57c9f30 
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@MatthijsBurgh
Fix styling
6884532 
Mega commit
@MatthijsBurgh
(driver) match goal scaling/margin with moveit
409c75f
@MatthijsBurgh
(driver) remove unused member variable
e560de3
@MatthijsBurgh
(driver) SensorDataQoS with keeping only 1 last msg
670f072
@MatthijsBurgh
Revert "(driver) SensorDataQoS with keeping only 1 last msg"
6ae37a9 
This reverts commit 670f072.
@MatthijsBurgh
(description) fix normals of meshes
1da8270
@MatthijsBurgh
(description) update collision meshes
b5a7e26
@MatthijsBurgh
Disable clang_tidy
c99326b
@MatthijsBurgh
(actions) run on jazzy & rolling
6da8684
@MatthijsBurgh
Revert "(actions)[temp] continue-on-error: true"
c80f5d7 
This reverts commit 1e32ff5.
@MatthijsBurgh
Update clang_format config
aa15517
@MatthijsBurgh
Many fixes (#2)
e8ec337
@MatthijsBurgh
(README) small table fix (#5)
cc98b9e
@DorusVBTI
initialization of arrays
7d9afd8
@DorusVBTI
skip first point in moveit PVT trajectory
fd8b123
@MatthijsBurgh
Feature/jazzy fixes (#6)
e2753af
@MatthijsBurgh
(description) add TM-s series
3dc6134
@MatthijsBurgh
(mod_urdf) drop urdf script, fix xacro script
5b444a9
@MatthijsBurgh
(driver) add lock modification MC-001
73d335a
@MatthijsBurgh
(driver) fix segfault
a09dea1
@MatthijsBurgh
(mod_urdf) also considare the build folder to find the workspace
b12e8a2
@MatthijsBurgh
(driver) default values for some variables in robot state
38d6e59
@MatthijsBurgh
(driver) remove RC_OK shortcut
287dbbe
@MatthijsBurgh
ScriptExit() -> Exit()
3e17ba7
@MatthijsBurgh
(driver) publish feedback on 100Hz
36ad897
@MatthijsBurgh
Fixes (#7)
3dc532e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthijsBurgh @DorusVBTI