Skip to content

fix: trim undefined from splat routes with no param #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: trim undefined from splat routes with no param #4558

wants to merge 1 commit into from

Conversation

tannerlinsley
Copy link
Collaborator

Fixes #4547

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c3d3aea.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 2m 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-01 18:27:04 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 1, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4558

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4558

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4558

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4558

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4558

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4558

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4558

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4558

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4558

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4558

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4558

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4558

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4558

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4558

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4558

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4558

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4558

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4558

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4558

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4558

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4558

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4558

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4558

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4558

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4558

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4558

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4558

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4558

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4558

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4558

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4558

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4558

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4558

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4558

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4558

commit: c3d3aea

schiller-manuel
schiller-manuel requested changes Jul 1, 2025
View reviewed changes
packages/router-core/tests/path.test.ts
@@ -523,6 +523,48 @@ describe('interpolatePath', () => {
).toBe(result)
})
})

describe('splat route missing parameter issue', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to should handle missing _splat parameter for splat route for

packages/router-core/tests/path.test.ts
describe('splat route missing parameter issue', () => {
it.each([
{
name: 'should handle missing _splat parameter for basic splat route',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the should handle missing _splat parameter for part in each name prop

schiller-manuel
schiller-manuel reviewed Jul 1, 2025
View reviewed changes
packages/router-core/src/path.ts
if (segmentPrefix || segmentSuffix) {
return `${segmentPrefix}${segmentSuffix}`
}
return undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in which cases does this return undefined still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schiller-manuel schiller-manuel schiller-manuel requested changes

Assignees
No one assigned
Labels
package: router-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

router: Splat route appending undefined
2 participants
@tannerlinsley @schiller-manuel