Skip to content

feat(solid-form): add createFormHook for solid-js. #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MAST1999
Copy link
Contributor

I was starting a new project and decided to use solid, and I found out that createHookForm was missing so here I am 😄

I don't have too much experience with solid, but I think this looks good.

Copy link

nx-cloud bot commented Jun 29, 2025

View your CI Pipeline Execution ↗ for commit 05528cd.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 48s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-30 00:04:56 UTC

@MAST1999
Copy link
Contributor Author

Will start the work on docs after getting the green light on the PR.

Copy link

pkg-pr-new bot commented Jun 29, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1597

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1597

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1597

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1597

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1597

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1597

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1597

commit: 05528cd

Copy link

codecov bot commented Jun 29, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.50%. Comparing base (4abbc8a) to head (05528cd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/solid-form/src/createFormHook.tsx 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
+ Coverage   89.24%   93.50%   +4.26%     
==========================================
  Files          31        3      -28     
  Lines        1432       77    -1355     
  Branches      366        4     -362     
==========================================
- Hits         1278       72    -1206     
+ Misses        137        5     -132     
+ Partials       17        0      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LeCarbonator
Copy link
Contributor

The feature's already in the works over at #1453 . Would you mind taking a look at it and giving feedback?

@MAST1999
Copy link
Contributor Author

The feature's already in the works over at #1453 . Would you mind taking a look at it and giving feedback?

Looks like it has the same changes I've made, I've just addressed the comments there and used the types that were defined in the React implementation, I guess.

We can change the target branch from main to that PR if we want to track it there.

@MAST1999
Copy link
Contributor Author

I'm using this PR in my project and fixing problems for now.

@MAST1999 MAST1999 force-pushed the add-solid-form-hook branch from afe9475 to ebd3774 Compare June 29, 2025 23:10
This fixes and issue where some parts of the form, like submitting didn't work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants