Centralize media match checks #13839
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #13788
WHAT is this pull request doing?
This PR fixes #13788 by introducing a caching mechanism for getLiveMatches.
Safari exhibited severe performance issues due to repeated calls to window.matchMedia. This change avoids re-computing media query matches by caching the result, improving performance and reducing unnecessary layout calculations.
🎩 checklist
☑️ Tested on multiple browsers and few public apps.
☑️ Tested screen resize events on all browser as well and everything worked as it should on resize as well.