feat(retry) when WithMaxDuration is used, it ignores the default MaxAttempts

[curzolapierre]

• Add a changelog entry in CHANGELOG.md

[leo-scalingo]

So if I do:

r = NewRetrier(WithoutMaxAttempt())

It will be set to 5, not really logical unfortunately

[curzolapierre]

It will be set to 5, not really logical unfortunately

Oh indeed, this case is not covered in tests.

So we face to the issue of default value here.
Or what about returning an error in this particular case

What would be the use case of retrier without MaxAttempts?
Does this mean we are expecting an infinite retry? Or we do necessarily want a limit, in which case we need to specify it

[leo-scalingo]

Actually I think it's better to

• Have good defaults
• Be explicit in the API, which means, no side effect

The condition you're adding is a kind of side effect which may lead to situations which are difficult to understood without reading the doc/code of the library.

So to me the question is:

• Is the current default un-practical and we want to change it?
• What would be the ideal explicit API for you?

[leo-scalingo]

See above comment