feat(cronsetup/request-id) Generate a unique request ID for each cron execution #1127
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-scalingo
force-pushed
the
feat/1126/cronsetup/request-id
branch
from
153abf3 to
1f2141f
Compare
leo-scalingo
force-pushed
the
feat/1126/cronsetup/request-id
branch
from
1f2141f to
405f4fb
Compare
leo-scalingo
force-pushed
the
feat/1126/cronsetup/request-id
branch
from
405f4fb to
5b37a44
Compare
| log = log.WithField("cron-job", j.Name) | ||
| log.Debug("Running cron job") | ||
| return logger.ToCtx(ctx, log) | ||
| requestID, err := uuid.NewV4() |
There was a problem hiding this comment.
It shouldn't happen but could you check that there is no RequestID already in the context ?
There was a problem hiding this comment.
I could even if indeed it shouldn't happen
EtienneM
changed the title
|
Just a friendly ping @leo-scalingo. It has some small conflicts and one last comment from John. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1126
CHANGELOG.md