Skip to content

Adding lang tests #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

rhys-h-walker
Copy link

Lang_tests have been added to the SOM core-lib repository which can be found here.

The framework to run these tests can be found in a separate pull request here. Which contains a README which explains how to run those tests.

@smarr smarr force-pushed the adding-lang-tests branch 2 times, most recently from e862c47 to 24cc77a Compare July 14, 2025 21:38
@smarr
Copy link
Member

smarr commented Jul 14, 2025

@rhys-h-walker I cleaned up the PR to really only have the relevant commits. Note also the comment for the first commit, I document where things are exactly from.

@smarr
Copy link
Member

smarr commented Jul 14, 2025

@ltratt we're in the process of adopting the yksom lang_tests. Are you fine with that?

There are a bunch of fixes already here, but I expect that there will be more changes to come in the future.
Many of the tests test "unspecified" behavior, and may change. But some of them are not quite correct in the first place. Though, the only example for a not quite correct test in this PR is 1489e69 I think.

Some other changes are needed to support case-insensitive file systems, mostly renaming things.
Others are about SOM enforcing that class names match the file names they are in.

@smarr
Copy link
Member

smarr commented Jul 14, 2025

@ltratt ah, and I should have mentioned: #128 is a Python-based reimplementation of the bits of https://github.com/softdevteam/lang_tester that we need for this, and some extensions to be able to run things on different SOMs. Mostly support for having files that document which tests are expected to fail.

@ltratt
Copy link

ltratt commented Jul 15, 2025

we're in the process of adopting the yksom lang_tests. Are you fine with that?

Of course, I'm very happy for you to do so! And I'm very happy to see a lang_tester clone (lang_tester itself is a sort of clone-extend-and-simplify of other things, so the cycle continues!).

smarr and others added 12 commits July 15, 2025 15:58
This adds the lang_tests folder from https://github.com/softdevteam/yksom/tree/master/lang_tests

The specific version is softdevteam/yksom@baef10d

As per https://github.com/softdevteam/yksom/blob/master/COPYRIGHT, the test code was licensed under Apache License 2 or the MIT license.
Since SOM is licensed under the MIT license, we chose it for the imported code.

Co-authored-by: Rhys Walker <rhys.h.walker@gmail.com>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- this avoids issues with case insensitive file names

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
The #~= operator is the operator corresponding to #==, i.e., reference equality.
The #<> operator is the value inequality in SOM.

Signed-off-by: Stefan Marr <git@stefan-marr.de>
- double?.som
- str_escape_unknown

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Co-authored-by: Rhys Walker <rhys.h.walker@gmail.com>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr smarr force-pushed the adding-lang-tests branch from 33bce72 to b2d8aa7 Compare July 15, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants