Update testing intro doc #4735
Merged
Update testing intro doc #4735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mats Wichmann <mats@linux.com>
mwichmann
added
the
testsuite
bdbaddog
reviewed
Jun 11, 2025
| the unit tests for the ``Builder.py`` module are in the | ||
| ``BuilderTests.py`` script. Unit tests tend to be based on assertions. | ||
| ``SCons/`` subdirectory (that is alongside the code they are testing) | ||
| and use the Python ``unittest`` module to perform assertion-based |
There was a problem hiding this comment.
Should include that files have to be named *Tests.py to be found.
There was a problem hiding this comment.
I thought that's what that section was saying?
There was a problem hiding this comment.
I don't see it in this section.. it's much later in the doc..
There was a problem hiding this comment.
I'm not seeing the reason for the fuss here. This is an "about" section, not a "how to" section. I can add these but it seems like extra noise.
There was a problem hiding this comment.
You removed it from the original, which I think is useful information to have up front.
bdbaddog
reviewed
Jun 11, 2025
bdbaddog
reviewed
Jun 11, 2025
bdbaddog
reviewed
Jun 11, 2025
bdbaddog
reviewed
Jun 11, 2025
bdbaddog
reviewed
Jun 11, 2025
bdbaddog
reviewed
Jun 11, 2025
Signed-off-by: Mats Wichmann <mats@linux.com>
Signed-off-by: Mats Wichmann <mats@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not affect SCons at all - only updates the document (which is eventually duplicated on the Wiki) about making use of the SCons test framework.
It's not going to be easy to review in the classical way, maybe just scan through the full doc and see if it makes sense this way?
https://scons.org/guidelines.html
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).