ENH: Improve parachute geometric parametrization

[ArthurJWH]

Pull request type

• Code changes (bugfix, features)

Checklist

• Tests for the changes have been added (if needed)
• Docs have been reviewed and added / updated
• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest tests -m slow --runslow) have passed locally
• CHANGELOG.md has been updated (if relevant)

Current behavior

Parachute radius is assumed to be fixed (=1.5m)

New behavior

Other than adding a radius parameter, there is also additional height and porosity parameters.
The default is still set to the current behavior.

Breaking change

• Yes
• No

[Copilot]

Pull Request Overview

This PR improves the parachute geometric parametrization by introducing new parameters (radius, height, and porosity) to provide a more flexible and accurate simulation. Key changes include:

• Adding lambda callbacks to update parachute_radius, parachute_height, and parachute_porosity in the simulation.
• Updating the added mass computation in flight dynamics to use parachute_radius and parachute_height.
• Extending the Parachute class to support the new parameters, with appropriate defaults and serialization.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
rocketpy/simulation/flight.py	Updated simulation callbacks and mass computation with new parameters.
rocketpy/rocket/parachute.py	Extended the Parachute class to include and serialize new parameters.

Comments suppressed due to low confidence (2)

rocketpy/simulation/flight.py:2002

• [nitpick] Consider adding a comment to explain the rationale behind the modified added mass formula using parachute_radius squared times parachute_height, clarifying the geometrical model or assumptions used.

        ma = ka * rho * (4 / 3) * np.pi * parachute_radius**2 * parachute_height

rocketpy/simulation/flight.py:2018

• Ensure that the variable 'z' is defined in this scope (for example, by extracting altitude from the state vector) to avoid potential runtime errors.

        az = (Dz - mp * self.env.gravity.get_value_opt(z)) / (mp + ma)

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.