Enh/acceleration earth to rocket frame #834
Conversation
DEV: Master to v1.10.0
REL: update to v1.10.0
adds deepwiki badge
Update README.md
monte_carlo_test.errors.txt
Outdated
There was a problem hiding this comment.
please remove these .txt files
There was a problem hiding this comment.
@Lucas-Prates , perhaps your latest PR introduced this problem of creating .txt when running Monte Carlo tests. Could you double check that please?
There was a problem hiding this comment.
I'll look into that didn't realised thoese were included. Thanks for pointing it out!
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new property to transform acceleration from the Earth frame to the Body frame, improving the simulation of rocket dynamics. It also updates the README with a new badge and the changelog with an entry for the new feature.
- Adds the acceleration_earth_to_body_frame property in the Flight class.
- Updates README.md to include a new Ask DeepWiki badge.
- Updates CHANGELOG.md with an entry for the new acceleration transformation feature.
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rocketpy/simulation/flight.py | Adds a new cached property for acceleration transformation |
| README.md | Introduces a new badge link |
| CHANGELOG.md | Documents the addition, but with a naming inconsistency |
Comments suppressed due to low confidence (1)
CHANGELOG.md:34
- The changelog entry refers to 'axial_acceleration', but the Flight class now implements 'acceleration_earth_to_body_frame'. Please update the changelog to reflect the correct property name.
- ENH: adds axial_acceleration attribute to the Flight class.- issue #529 [#834] (https://github.com/RocketPy-Team/RocketPy/pull/834)
There was a problem hiding this comment.
In terms of coding, it is quite fine to me already.
I would just say that we need to implement unit tests for this method before merging.
@MateusStano, what do you think in terms of physics/dynamics? Anything to comment on?
|
I really love when people have the initiative to open up a PR to this repo. It makes our work so valuable and collaborative. Thanks!! |
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
Currently, there is no functionality in the code that performs the transformation of acceleration from the Earth frame to the Body frame.
New behavior
This PR adds acceleration tranformation from Earth frame to Body frame.
Breaking change
Additional information
I didn't add the feature as "axial_acceleration" as specified in the original issue in order to avoid confusion. Instead, I chose a clearer name "acceleration_earth_to_body_frame" which better represents what was originally in mind.