I added an instance variable to make this work in multi-tenancy #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should remember to update the documentation once this goes in so that users are aware of the Additionally, do we want to default |
Add default as rapidapi if the parameter is not provided
|
@s-giovanni just added the change that should prevent existing integrations from breaking. Let me do another deeper dive before we merge though. |
LMS007
reviewed
May 4, 2022
| @@ -15,6 +15,9 @@ console.log(`Executing Test ID: ${TEST_ID}`); | |||
| const LOCATION = core.getInput('location'); | |||
| console.log(`Executing In Location: ${LOCATION}`); | |||
|
|
|||
| const INSTANCE = core.getInput('instance') || "rapidapi"; | |||
There was a problem hiding this comment.
TODO: define input in action.yml, possibly with a default "rapidapi.com"
| @@ -30,7 +33,10 @@ function sleep(time) { | |||
| core.group('Execute Test', async () => { | |||
| // 1. Trigger Test | |||
| const envString = ENVIRONMENT ? `&enviroment=${ENVIRONMENT}` : ''; | |||
| const instance = INSTANCE; | |||
There was a problem hiding this comment.
I think if we make this the full domain w/ .com then we can just call this DOMAIN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.