Skip to content

log-server: drop run_status from log CSV export #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

log-server: drop run_status from log CSV export #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/three-pandas-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@lightmill/log-server': major
---

Drop run_status column from CSV export. This column is not usually needed when fetching an experiment's results, and adds noise.
12 changes: 6 additions & 6 deletions packages/log-server/__tests__/__snapshots__/app-logs.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,9 @@ exports[`LogServer: get /logs > returns logs as csv by default 1`] = `
`;

exports[`LogServer: get /logs > returns logs as csv by default 2`] = `
"type,experiment_name,run_name,run_status,mock_col_1,mock_col_2,mock_col_3
getLogs:type-1,getLogs:experimentName-1,getLogs:runName-1,running,log1-mock-value1,log1-mock-value2,
getLogs:type-2,getLogs:experimentName-2,getLogs:runName-2,completed,log2-mock-value1,log2-mock-value2,log2-mock-value3
"type,experiment_name,run_name,mock_col_1,mock_col_2,mock_col_3
getLogs:type-1,getLogs:experimentName-1,getLogs:runName-1,log1-mock-value1,log1-mock-value2,
getLogs:type-2,getLogs:experimentName-2,getLogs:runName-2,log2-mock-value1,log2-mock-value2,log2-mock-value3
"
`;

Expand All @@ -226,9 +226,9 @@ exports[`LogServer: get /logs > returns logs as csv if csv is the first supporte
`;

exports[`LogServer: get /logs > returns logs as csv if csv is the first supported format in the Accept header 2`] = `
"type,experiment_name,run_name,run_status,mock_col_1,mock_col_2,mock_col_3
getLogs:type-1,getLogs:experimentName-1,getLogs:runName-1,running,log1-mock-value1,log1-mock-value2,
getLogs:type-2,getLogs:experimentName-2,getLogs:runName-2,completed,log2-mock-value1,log2-mock-value2,log2-mock-value3
"type,experiment_name,run_name,mock_col_1,mock_col_2,mock_col_3
getLogs:type-1,getLogs:experimentName-1,getLogs:runName-1,log1-mock-value1,log1-mock-value2,
getLogs:type-2,getLogs:experimentName-2,getLogs:runName-2,log2-mock-value1,log2-mock-value2,log2-mock-value3
"
`;

Expand Down
7 changes: 1 addition & 6 deletions packages/log-server/src/csv-export.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,7 @@ import { mapKeys, pickBy, pipe } from 'remeda';
import { type AllFilter, type Log, SQLiteStore as Store } from './store.js';
import { withSnakeCaseProps } from './utils.js';

const csvLogColumns: Array<keyof Log> = [
'type',
'experimentName',
'runName',
'runStatus',
];
const csvLogColumns: Array<keyof Log> = ['type', 'experimentName', 'runName'];
const renamedLogColumns: Partial<Record<keyof Log, string>> = {};

export function csvExportStream(
Expand Down