[Minor] Change overlays >255 to use NewINIFormat == 5 #1692
+62
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Docs here |
Coronia
requested changes
Jun 25, 2025
| if (ScenarioClass::NewINIFormat >= 5) | ||
| ByteWriter.PutWord(static_cast<unsigned char>(nOverlay)); | ||
| else | ||
| ByteWriter.PutByte(static_cast<unsigned short>(nOverlay)); |
There was a problem hiding this comment.
apparently PutWord is for unsigned short while PutByte is for unsigned char here, is it being opposite here? If not, then the compile warning should be fixed
Starkku
force-pushed
the
develop
branch
2 times, most recently
from
b429215 to
280b1c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes overlays with ID > 255 to be written in the same
[OverlayPack]but as words, and with NewINIFormat == 5, to be in line with Vinifera and upcoming WAE changes so that this can actually be made use of.