-
-
Notifications
You must be signed in to change notification settings - Fork 159
chore: update pdc docs #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think you could provide more JavaDoc links here and there
b6bc21d
to
fb56eef
Compare
As I see it the docs only link to stuff one timer per document and I think that is fine |
ahhh, you can't use double underline? |
a3cba69
to
abfd04b
Compare
``` | ||
|
||
::: | ||
|
||
|
||
## Read-only containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be just an aside
## Read-only containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because then it wouldn't be in the sidebar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's supposed to be a full-fledged section, it should elaborate on the purpose and benefit of accessing a view instead of a mutable version in general, not just a single note that duplicates information from the "Storing on different objects" section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should elaborate on the purpose and benefit of accessing a view instead of a mutable version in general
What should I elaborate on (other than not accidentally modifying the data)?
Also there's no "benefit", it is just that you can't get a normal container from e.g. an OfflinePlayer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well currently the purpose of the view is to side-step technical limitations, like the ItemMeta snapshot costliness or the file I/O intensity of having a mutable offline player PDC, which is pretty noteworthy
fix: javadoc links Co-authored-by: Matouš Kučera <mk@kcra.me>
e8566ba
to
bb725f5
Compare
354b6d1
to
76e717a
Compare
223e87c
to
33dc0d4
Compare
33dc0d4
to
074bce9
Compare
Uh oh!
There was an error while loading. Please reload this page.