fix(sdk): Refactored logic and consolidated connected status control #44
+63
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During integration testing I noticed that if the GetProductInfoAsync method was called prior to TestConnectionAsync, the TestConnectionAsync method would return a false indicating that the connection test failed.
After reviewing I noticed that teh GetProductInfoAsync would modify the m_isConnected property, which would cause the TestConnectionAsync to fail.
Solution was to isolate the m_IsConencted to only be controlled by the TestConnectionAsync since it's the only method currently that uses the property. I also refactored the logic of TestConnectionAsync to be a bit clearer on the methods checks.
Also updated the authentication check to use the project properties endpoint instead of doc. Doc will be a larger return call for Kepware Server instances.
I did some smoke testing with the SyncService and it seems to be working as expected.