-
Notifications
You must be signed in to change notification settings - Fork 0
🚀 feat(tests) add time_series named 'a/b' in sample tests #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
Do you see the problem now ? |
Can't we just forbid a "/" in the name of a time series (raises an error when trying to add one to a sample, for instance ?) |
in the future, time_series might not be stored in files named by the time_series name, see #96 I would rather update the disk format to avoid using time_series name in filenames, as it is the case for other features (scalars, meshes, fields...), but it implies to respect #14, @casenave Should this be done for Milestone v0.2.0 ? As a workaround, for Milestone v0.1.7, I would rather implement something like:
|
@xroynard I think the time series are not really used for the moment, so ok for the renaming hack. Concerning retrocompatibility, it is important but I think we can impose it after a v1.0 version and allow us major modifications in the data model before - which would imply updating our public datasets |
Maybe you were rigth, see https://cgns.org/standard/SIDS/convention.html It is specified:
|
Closes #82