🐛 fix(stats.py) correct shape condition in add_samples #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
…, better type checking, better modularity
This was referenced Jun 24, 2025
…nt between samples + improve tests for type checking + tests for new methods
|
@xroynard thanks for the modifications ! I improved the coverage, but two instructions are still not checked in tests, and I have difficulties understanding this part of the code -> adding a review |
casenave
commented
Jun 28, 2025
src/plaid/utils/stats.py
Outdated
| # flatten corresponding stat | ||
| if ( | ||
| stat_key in self._stats | ||
| ): # TODO: ADD THIS IN TESTS |
src/plaid/utils/stats.py
Outdated
| if ( | ||
| isinstance(list_of_arrays[i], np.ndarray) | ||
| and list_of_arrays[i].ndim == 1 | ||
| ): # TODO: ADD THIS IN TESTS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.