Skip to content

🎉 Torch geometric plaid dataset loader #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

casenave
Copy link
Member

No description provided.

@casenave casenave marked this pull request as draft May 30, 2025 12:56
@CLAassistant
Copy link

CLAassistant commented May 30, 2025

CLA assistant check
All committers have signed the CLA.

@bstaber bstaber changed the title Torch geometric plaid dataset loader 🎉 Torch geometric plaid dataset loader May 31, 2025
@casenave casenave force-pushed the main branch 2 times, most recently from 5351341 to cb91813 Compare June 1, 2025 10:26
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 149 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/plaid/utils/dataset_loader.py 0.00% 149 Missing ⚠️

📢 Thoughts on this report? Let us know!

@casenave
Copy link
Member Author

casenave commented Jun 2, 2025

need to add tests, and a way to deal with optional dependancies (here torch and torch-geometric)

@casenave
Copy link
Member Author

casenave commented Jun 2, 2025

Other idea: move code with optional dependencies in separate folders of src and configure pytest not to consider these folders for coverage stats and for "pytest tests". In addition, document these functionalities in notebooks in the doc. This way, complicated env are to be handled by readthedocs workflows only, and we can track in the docs when functionalities stop working.
This is to prevent complicating too much the github actions and repo, in the meantime of finding more suitable solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants