Skip to content

🎉 scikit-learn pipeline models in examples #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Conversation

casenave
Copy link
Member

No description provided.

@casenave casenave added this to the version 0.2.0 milestone Jun 30, 2025
@casenave casenave requested a review from a team as a code owner June 30, 2025 12:28
Copy link

gitnotebooks bot commented Jun 30, 2025

Review these changes at https://app.gitnotebooks.com/PLAID-lib/plaid/pull/101

@casenave casenave marked this pull request as draft June 30, 2025 12:28
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@casenave
Copy link
Member Author

casenave commented Jun 30, 2025

@xroynard This PR contains additions in the dataset class (mainly a mechanism for calling slices of dataset, returning a dataset), and a first example of scikit-learn pipeline acting directly on plaid objects, in the examples/pipelines folder. To me, even if we change the design later, we can merge this PR for the modifications of datasets and since the pipeline are proposed as examples for the moment.

edit: still working on it, marked as draft

@casenave casenave marked this pull request as ready for review June 30, 2025 18:53
@casenave casenave marked this pull request as draft July 1, 2025 05:04
casenave added 3 commits July 1, 2025 07:21
…ing a global dict and specifying only arguments to be optimized by GridSearchCV (n_components of PCA for the moment)
Copy link
Contributor

@bstaber bstaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the full knowledge to be able to properly review so I'm just dropping a few comments for stuff outisde the examples/ folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants