Instrument CREATE and CREATE2 gas func #489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishkaRogachev
changed the base branch from
cbp-feature
to
instrument_call_gas_func
MishkaRogachev
commented
Jul 18, 2025
| @@ -327,15 +327,15 @@ func gasCreate2(evm *EVM, contract *Contract, stack *Stack, mem *Memory, memoryS | |||
| if wordGas, overflow = math.SafeMul(toWordSize(wordGas), params.Keccak256WordGas); overflow { | |||
| return multigas.ZeroGas(), 0, ErrGasUintOverflow | |||
| } | |||
| // TODO(NIT-3484): Update multi dimensional gas here | |||
| if gas, overflow = math.SafeAdd(gas, wordGas); overflow { | |||
| if overflow = multiGas.SafeIncrement(multigas.ResourceKindComputation, wordGas); overflow { | |||
There was a problem hiding this comment.
CREATE / CREATE2 are pure computation cost:
There was a problem hiding this comment.
Shouldn't this be an inline comment rather than a PR conversation comment?
Like we want the reasoning to be available to folks reading the code.
eljobe
requested changes
Jul 18, 2025
| @@ -327,15 +327,15 @@ func gasCreate2(evm *EVM, contract *Contract, stack *Stack, mem *Memory, memoryS | |||
| if wordGas, overflow = math.SafeMul(toWordSize(wordGas), params.Keccak256WordGas); overflow { | |||
| return multigas.ZeroGas(), 0, ErrGasUintOverflow | |||
| } | |||
| // TODO(NIT-3484): Update multi dimensional gas here | |||
| if gas, overflow = math.SafeAdd(gas, wordGas); overflow { | |||
| if overflow = multiGas.SafeIncrement(multigas.ResourceKindComputation, wordGas); overflow { | |||
There was a problem hiding this comment.
Shouldn't this be an inline comment rather than a PR conversation comment?
Like we want the reasoning to be available to folks reading the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NIT-3482
Instrument CREATE and CREATE2 opcode with multigas calculations:
gasCreate2funcgasCreateEip3860for EIP-3860 (introduce init code size)Note: waits #486 to be merged, temporary points on
instrument_call_gas_funcbranch