Skip to content

Remove run.sh entrypoint for Prometheus #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reversesigh
Copy link

When running multiple DVnodes, it can be easy to integrate them into a single prometheus job like this:

  - job_name: charon
    static_configs:
      - targets: [charon:20120,charon:20220]
    static_configs:
      - targets: [lodestar:20164,lodestar:20264]
  - job_name: lodestar

However with the entrypoint for run.sh, these changes get overwritten whenever the container relaunches. Lido already has this removed from their fork by default - and I think it makes sense to make it easier to make adjustments to prometheus.yml by default.

When running multiple DVnodes, it can be easy to integrate them into a single prometheus job like this:

```
  - job_name: charon
    static_configs:
      - targets: [charon:20120,charon:20220]
    static_configs:
      - targets: [lodestar:20164,lodestar:20264]
  - job_name: lodestar
```

However with the entrypoint for run.sh, these changes get overwritten whenever the container relaunches. Lido already has this removed from their fork by default - and I think it makes sense to make it easier to make adjustments to prometheus.yml by default.

Signed-off-by: james. <86951780+reversesigh@users.noreply.github.com>
@aly-obol
Copy link
Contributor

aly-obol commented Feb 3, 2025

@reversesigh This repo mainly deploys and monitors a single node. For multiple-node deployment, there is another repo where we don't use the Prometheus run script.

Also, this script centralizes all the config in a single .env file without manually editing the Prometheus yaml file to add the monitoring token and endpoint. We are open to changing the deployment while the goals above remain intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants