Skip to content

Fix discovery of nvidia-fs devices in non-privileged containers #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elezar
Copy link
Member

@elezar elezar commented Jun 16, 2025

The /dev/nvidia-fs* device nodes for GDS are not greated at the driver root when running a containerized driver and are always created in /.

This change updates the search path for these device nodes so that non-privilged containers also have the device nodes injected.

The /dev/nvidia-fs* device nodes for GDS are not greated at the
driver root when running a containerized driver and are always
created in /.

This change updates the search path for these device nodes so that
non-privilged containers also have the device nodes injected.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar added this to the v1.18.0 milestone Jun 16, 2025
@elezar elezar requested a review from cdesiniotis June 16, 2025 17:23
@elezar elezar self-assigned this Jun 16, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15687584038

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 33.621%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/modifier/gated.go 0 1 0.0%
pkg/nvcdi/gds.go 0 1 0.0%
internal/discover/gds.go 0 3 0.0%
Totals Coverage Status
Change from base Build 15683627970: -0.003%
Covered Lines: 4325
Relevant Lines: 12864

💛 - Coveralls

@elezar elezar marked this pull request as draft June 19, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants