[BUG fix] solve the CI bug of router fusion #1944
Open
+146
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tongliu <tongliu@nvidia.com>
Signed-off-by: tongliu <tongliu@nvidia.com>
Signed-off-by: tongliu <tongliu@nvidia.com>
for more information, see https://pre-commit.ci
|
/te-ci pytorch |
timmoon10
approved these changes
Jul 11, 2025
Comment on lines
+151
to
+156
| # Construct the special logits to avoid inf in the sigmoid function | ||
| logits = 1 + torch.arange(num_experts, device="cuda", dtype=dtype) * 0.01 | ||
| logits = logits.unsqueeze(0).repeat(num_tokens, 1) | ||
| random_values = torch.rand(num_tokens, num_experts, device="cuda") | ||
| _, indices = torch.sort(random_values, dim=1) | ||
| logits = torch.gather(logits, 1, indices) |
There was a problem hiding this comment.
Can you explain how this helps avoid infs? Was the problem that logits became too large, causing sigmoid to output 1.0 in multiple entries? Also, I don't understand the benefit from forcing logits >= 1. Previously we had logits >= 0 and sigmoid(0) = 0.5, so I wouldn't expect us to have had divide-by-zero problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for Router Fusion:
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: