mxfp8 (for all gemm layouts) is not supported on 120+ arch yet #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
timmoon10
previously approved these changes
Jul 9, 2025
ksivaman
reviewed
Jul 9, 2025
| @@ -64,7 +66,7 @@ def check_fp8_block_scaling_support() -> Tuple[bool, str]: | |||
|
|
|||
| def get_default_fp8_recipe() -> Recipe: | |||
| """FP8 recipe with default args.""" | |||
| if get_device_compute_capability() >= (10, 0): # blackwell and above | |||
| if check_mxfp8_support()[0]: | |||
There was a problem hiding this comment.
Let's use the subchannel fp8 recipe for default for 10+ archs that don't have mxfp8 support
Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
for more information, see https://pre-commit.ci
sudhakarsingh27
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MXFP8 is not supported on 120+ arch yet (for all gemm layouts). Add check to not default to MXFP8 recipe for those archs.
Fixes # (internal)
Type of change
Changes
Please list the changes introduced in this PR:
check_mxfp8_support: returnsFalsefor arcs 120+get_default_fp8_recipe: usescheck_mxfp8_supportinstead of directly checkingget_device_compute_capability.Checklist: