-
Notifications
You must be signed in to change notification settings - Fork 451
[Common] Skip cuDNN 9.10.0/9.10.1 due to bugs #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
/te-ci pytorch L1 L0 |
for more information, see https://pre-commit.ci
Pipeline 31306522 for 9.10.0 + 25.06 + 12.9 |
@@ -47,6 +47,7 @@ | |||
from transformer_engine.pytorch.tensor.utils import replace_raw_data | |||
from transformer_engine.pytorch.distributed import checkpoint | |||
from test_numerics import reset_rng_states, dtype_tols | |||
from fused_attn.test_fused_attn import ModelConfig, _get_attention_backends |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_fused_attn.py
is kind of a strange place to keep ModelConfig
. It's indicating that these tests are becoming over-tuned to attention. We could avoid this refactor by moving test_sanity_attention_extra_state
into the fused attention tests:
TransformerEngine/tests/pytorch/test_sanity.py
Line 1119 in 7b249ae
def test_sanity_attention_extra_state(model, dtype): |
Alternatively, we could move ModelConfig
from test_fused_attn.py
into utils.py
. It has many attention-specific options though, so I'd prefer having separate implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
cuDNN fixed a few bugs in cuDNN 9.10.2 and this PR is to:
Type of change
Changes
Please see description.
Checklist: