Skip to content

[BUILD] Exclude ninja from required packages #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

phu0ngng
Copy link
Collaborator

@phu0ngng phu0ngng commented Jul 7, 2025

Description

JAX images do not come with ninja by default; hence, one should not enforce ninja as a required package.
Enforcing ninja as a required package causes build failures when ninja is absent.
In fact, when ninja is absent, our build_ext.py could fall back to use MakeFile.

This PR removes ninja from the required package list in pyproject.toml.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@phu0ngng phu0ngng requested a review from ksivaman July 7, 2025 18:42
@phu0ngng
Copy link
Collaborator Author

phu0ngng commented Jul 7, 2025

/te-ci L0

Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go this route, we should also update the README:

* **Source Build Requirements:** CMake 3.18+, Ninja, Git 2.17+, pybind11 2.6.0+

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about this change, needs some thinking. Our build requirements should not be dictated by what is pre-installed in the JAX image.

Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Ninja is sufficiently useful that the build system should install it by default. If a user really wants to avoid it, they can build with --no-dependencies and the build will still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants