Skip to content

[Common] Optimize KV cache related kernels #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cyanguwa
Copy link
Collaborator

Description

This PR improves the runtime performance of the reindex_kv_cache and copy_to_kv_cache kernels.

Example problem size: b=64, max_s=1024, current_s=128, new_s=8, h=12, d=256, on Hopper
Before: reindex: 4.8ms, copy: 1.3ms
After: reindex: 46us, copy: 13us

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Optimize reindex and copy kernels in KV caching

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
@cyanguwa cyanguwa requested a review from sudhakarsingh27 June 30, 2025 23:42
@cyanguwa
Copy link
Collaborator Author

cyanguwa commented Jul 1, 2025

/te-ci pytorch L0

@cyanguwa cyanguwa added the 2.6.0 label Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant