pipeline aware cpu offload #1886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhb8125
reviewed
Jun 17, 2025
| self._b_event = PipelineOffloadManager.get_instance()._b_event | ||
| self.do_offload = offload | ||
|
|
||
| def is_first_last_layer(self): |
There was a problem hiding this comment.
The naming is ambiguous. It returns true when the current layer is the last layer and the current vpp chunk is the first one or the last one, is my understanding correct?
lhb8125
reviewed
Jun 17, 2025
| return self.cur_backward_chunk().tensor_pop(saved_state) | ||
|
|
||
|
|
||
| OFFLOAD_TAG = "offloading_mlp_input" |
There was a problem hiding this comment.
Do we only support offloading mlp input?
Signed-off-by: Tim Moon <tmoon@nvidia.com> Signed-off-by: liuzhenhai93 <liuzhenhai93@outlook.com>
Signed-off-by: liuzhenhai93 <liuzhenhai93@outlook.com>
liuzhenhai93
force-pushed
the
pp_aware_offload
branch
from
935f19c to
b9ac46a
Compare
for more information, see https://pre-commit.ci
|
Hi, thank you for the PR. We are working on some bigger changes in CPU Offload so I think we will need to sync. I reached out to @lhb8125. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pipeline aware cpu offload
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: