Skip to content

feat: Add Minecraft Account linking endpoints. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

MerchantCalico
Copy link
Member

@MerchantCalico MerchantCalico commented Jun 19, 2025

Resolves #3

Adds Minecraft account linking related endpoints for the Discord bot to access.

References:
https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow
https://minecraft.wiki/w/Microsoft_authentication
https://minecraft.wiki/w/Mojang_API

Little Notes

  • The code challenge endpoint is required for the bot's link sent to the end user, it's required because of the frontend being different to the backend.
  • The Mojang Public Key is publicly in the repo, which I don't think is really an issue as it's on the Minecraft Wiki page for Microsoft Authentication anyways.
  • I have not tested with users who own Minecraft: Java Edition through Xbox Game Pass, I'm unsure if the game ownership code would count for them.

@MerchantCalico MerchantCalico requested a review from UltrusBot June 19, 2025 02:57
Copy link
Contributor

@Oliver-makes-code Oliver-makes-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MerchantCalico MerchantCalico requested a review from sylv256 June 21, 2025 01:31
Copy link
Member

@sylv256 sylv256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things

@MerchantCalico MerchantCalico requested a review from sylv256 July 14, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Minecraft Account linking endpoint
3 participants