feature: filter out internal build suffix

[ekitagawa]

Description

• feature: filter out internal build suffix

Why make this change

Installation of an internal MCR build fails when I set it like this.

  "mcr":
    "channel": "test-25.0.12/fips"
    "installURLLinux": "https://get.mirantis.com/"
    "installURLWindows": "https://get.mirantis.com/install.ps1"
    "repoURL": "https://repos-internal.mirantis.com"
    "version": "25.0.12-tp1"

I get this output

▶ launchpad version
version: 1.5.13-tp2
commit: fd80698b975657d1a0729bedd07e6e8e7696d962

▶ launchpad apply
.
.
.
INFO ==> Running phase: Validate Facts
INFO See /Users/eiichi.kitagawa/.mirantis-launchpad/cluster/4O7MR4/apply.log for more logs
FATA failed to apply cluster: failed to apply MKE: phase failure: Validate Facts => validation failed
MCR version and channel don't match, which is required for versions >= 25.0.0; MCR version does not match channel-version '25.0.12' vs '25.0.12-tp1'

Related Links

PRODENG-3068

Testing

Test run with the proposed fix.

Unit tests show the newly added tests as well as preexisting tests works.

▶ go test -v pkg/product/common/api/mcr_config_validate_test.go
=== RUN   Test_ValidateNil
--- PASS: Test_ValidateNil (0.00s)
=== RUN   Test_ValidateNilFIPS
--- PASS: Test_ValidateNilFIPS (0.00s)
=== RUN   Test_ValidateEmptyVersion
--- PASS: Test_ValidateEmptyVersion (0.00s)
=== RUN   Test_ValidateInvalidVersion
--- PASS: Test_ValidateInvalidVersion (0.00s)
=== RUN   Test_ValidateMissingChannelVersion
--- PASS: Test_ValidateMissingChannelVersion (0.00s)
=== RUN   Test_ValidateWrongChannelVersion
--- PASS: Test_ValidateWrongChannelVersion (0.00s)
=== RUN   Test_ValidateWrongChannelVersionFIPS
--- PASS: Test_ValidateWrongChannelVersionFIPS (0.00s)
=== RUN   Test_ValidateIncompleteChannelVersion
--- PASS: Test_ValidateIncompleteChannelVersion (0.00s)
=== RUN   Test_ValidateIncompleteChannelVersionFIPS
--- PASS: Test_ValidateIncompleteChannelVersionFIPS (0.00s)
=== RUN   Test_ValidateWildcardChannelVersion
--- PASS: Test_ValidateWildcardChannelVersion (0.00s)
=== RUN   Test_ValidateWildcardChannelVersionFIPS
--- PASS: Test_ValidateWildcardChannelVersionFIPS (0.00s)
=== RUN   Test_ValidateInternalBuild
--- PASS: Test_ValidateInternalBuild (0.00s)
=== RUN   Test_ValidateInternalBuildFIPS
--- PASS: Test_ValidateInternalBuildFIPS (0.00s)
PASS
ok  	command-line-arguments	0.430s